[ProFTPD-committers] [Bug 3640] rpmbuild on CentOS5.5 (64bit): "File not found by glob"

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3640

TJ Saunders <***@castaglia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@city-fan.org,
| |***@castaglia.org

--- Comment #1 from TJ Saunders <***@castaglia.org> 2011-04-07 00:12:23 EDT ---
This is an rpmbuild bug, not a proftpd bug. See:

http://forums.proftpd.org/smf/index.php/topic,5393.0.html

for the full details, including the link to the rpm bug which is the root of
it.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3640

--- Comment #2 from Paul Howarth <***@city-fan.org> 2011-04-07 13:04:40 EDT ---
I'm happy to take a look at this and revamp the spec, but I'd like to know what
the goals of the spec are first.

The comments at the top suggest that there are a minimal set of modules built
by default and that others (e.g. mod_ban) can be requested using --with options
to rpmbuild. However, the --with handling only applies to a small number of the
modules actually and most of the rest are built by default. I attempted a
default build for CentOS5 x86_64 and didn't get as far as the original reporter
here because mod_ban was enabled by default and I hit Bug #3534.

So, are we looking for a package that matches the comments, or one that builds
most modules by default and only makes optional the ones that pull in
additional dependencies (such as the mysql/postgresql/SSL modules)?

It would also be useful to know which distributions the spec targets; I can
build for any Fedora / CentOS release from CentOS 3 onwards but can't test on
SuSE, Mandriva etc. Are there people from these distributions available for
testing?

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3640

--- Comment #3 from Paul Howarth <***@city-fan.org> 2011-04-07 13:07:34 EDT ---
By the way, there are 1.3.3e packages ready for testing for Fedora/EPEL here:

http://koji.fedoraproject.org/koji/packageinfo?packageID=3520

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3640

--- Comment #4 from TJ Saunders <***@castaglia.org> 2011-04-07 13:29:40 EDT ---
The .spec file that's provided is a patchwork of contributions over the years;
it has no explicit "design", as far as I know. That said, I think that most
users would prefer an RPM that builds most modules by default and only makes
optional the ones that pull in additional dependencies (such as the
mysql/postgresql/SSL modules).

As for target platforms, I would love to have it work for the platforms you
know best; other contributors can hopefully make it work for those other
platforms as needed. The provided .spec file was intended to be "good enough"
for people who wanted to use rpmbuild; it wasn't meant to be an end-all, be-all
.spec file that must be used by any RPM packagers. But hopefully it wouldn't
become too platform-specific. (I admit that my knowledge of rpmbuild and .spec
files is quite minimal, so I'm not sure what can and can't be done with them
with regard to platform-specific conditionals.)

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3640

--- Comment #5 from Paul Howarth <***@city-fan.org> 2011-04-07 14:39:09 EDT ---
It's usually possible to make a spec file that'll work with different
distributions but I'd need to know what the differences/problems are. Often
it's different package names for libraries, different install locations etc.

I'll have a go at the 1.3.3 version when I've got a bit of time, and it's
shouldn't be too hard to migrate that to trunk.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3640

--- Comment #6 from takato <***@fujimic.com> 2011-04-07 23:57:19 EDT ---
I should've reported executed commands.

First, I try to rpmbuild and no options.

rpmbuild -ba SPECS//proftpd.spec

but error occurred that is related to "mod_ban".( Bug #3534 ?)
So I try to rpmbuild with "--with ctrls" option.

rpmbuild -ba SPECS/proftpd.spec --with ctrls

by the way,
I rewrite .spec file and I try rpmbuild, so build succeed.

# diff SPECS/proftpd.spec SPECS/proftpd.spec.bak
363c363
< /usr/lib/pkgconfig/*.pc
---

%{_libdir}/pkgconfig/*.pc

Is it rpm's bug? shall I change state to resolved?

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3640

***@artic.edu changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@artic.edu

--- Comment #7 from ***@artic.edu 2011-04-28 16:54:15 EDT ---
The bug is in the specfile.

I believe this patch is a proper fix:

--- proftpd.spec.orig 2011-04-28 15:39:26.000000000 -0500
+++ proftpd.spec 2011-04-28 15:40:08.000000000 -0500
@@ -217,6 +217,7 @@
--prefix=%{prefix} \
--sysconfdir=%{_sysconfdir} \
--localstatedir=%{_localstatedir}/run \
+ --with-pkgconfig=%{_lib}/pkgconfig \
--mandir=%{_mandir} \
%{?_with_ipv6:--enable-ipv6} \
%{?_with_ctrls:--enable-ctrls} \

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3640

--- Comment #8 from Paul Howarth <***@city-fan.org> 2011-04-28 17:01:07 EDT ---
(In reply to comment #7)

Post by b***@horde.net
The bug is in the specfile.
--- proftpd.spec.orig 2011-04-28 15:39:26.000000000 -0500
+++ proftpd.spec 2011-04-28 15:40:08.000000000 -0500
@@ -217,6 +217,7 @@
--prefix=%{prefix} \
--sysconfdir=%{_sysconfdir} \
--localstatedir=%{_localstatedir}/run \
+ --with-pkgconfig=%{_lib}/pkgconfig \
--mandir=%{_mandir} \
%{?_with_ipv6:--enable-ipv6} \
%{?_with_ctrls:--enable-ctrls} \

I'm working on overhauling the spec and already have that change included. I've
lots of things still to change but what I have so far is here:

http://trac.city-fan.org/cfo-trac/browser/proftpd/branches/upstream-1.3.3/proftpd.spec

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3640

--- Comment #9 from ***@artic.edu 2011-04-28 17:29:25 EDT ---
As long as you're reworking the specfile, it might be worthwhile installing the
perl scripts from contrib/

This is the patch we're using as of this afternoon:

--- proftpd.spec.orig 2011-04-28 15:39:26.000000000 -0500
+++ proftpd.spec 2011-04-28 16:24:16.000000000 -0500
@@ -217,6 +217,7 @@
--prefix=%{prefix} \
--sysconfdir=%{_sysconfdir} \
--localstatedir=%{_localstatedir}/run \
+ --with-pkgconfig=%{_lib}/pkgconfig \
--mandir=%{_mandir} \
%{?_with_ipv6:--enable-ipv6} \
%{?_with_ctrls:--enable-ctrls} \
@@ -259,6 +260,7 @@
install -m 644 contrib/dist/rpm/proftpd.logrotate
$RPM_BUILD_ROOT/etc/logrotate.d/proftpd
mkdir -p $RPM_BUILD_ROOT/etc/xinetd.d/
install -m 644 contrib/dist/rpm/xinetd $RPM_BUILD_ROOT/etc/xinetd.d/proftpd
+ install -m 644 contrib/ftpasswd contrib/ftpmail contrib/ftpquota
$RPM_BUILD_ROOT/usr/bin/
# We don't want this dangling symlinks to make it into the RPM
rm -f contrib/README.mod_sql

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3640

--- Comment #10 from ***@artic.edu 2011-04-28 17:38:00 EDT ---
Sorry...

mode should be 755 not 644.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3640

--- Comment #11 from Paul Howarth <***@city-fan.org> 2011-04-28 17:42:43 EDT ---
(In reply to comment #9)

Post by b***@horde.net
As long as you're reworking the specfile, it might be worthwhile installing the
perl scripts from contrib/
--- proftpd.spec.orig 2011-04-28 15:39:26.000000000 -0500
+++ proftpd.spec 2011-04-28 16:24:16.000000000 -0500
@@ -217,6 +217,7 @@
--prefix=%{prefix} \
--sysconfdir=%{_sysconfdir} \
--localstatedir=%{_localstatedir}/run \
+ --with-pkgconfig=%{_lib}/pkgconfig \
--mandir=%{_mandir} \
%{?_with_ipv6:--enable-ipv6} \
%{?_with_ctrls:--enable-ctrls} \
@@ -259,6 +260,7 @@
install -m 644 contrib/dist/rpm/proftpd.logrotate
$RPM_BUILD_ROOT/etc/logrotate.d/proftpd
mkdir -p $RPM_BUILD_ROOT/etc/xinetd.d/
install -m 644 contrib/dist/rpm/xinetd $RPM_BUILD_ROOT/etc/xinetd.d/proftpd
+ install -m 644 contrib/ftpasswd contrib/ftpmail contrib/ftpquota
$RPM_BUILD_ROOT/usr/bin/
# We don't want this dangling symlinks to make it into the RPM
rm -f contrib/README.mod_sql

Those get installed by default in 1.3.4, so it's a reasonable request. However,
they do pull in perl and a bunch of modules as dependencies that wouldn't
otherwise be needed, so I'm toying with the idea of shifting them out to a
subpackage, or maybe including them conditionally (e.g. using --with utils or
something similar).

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3640

--- Comment #12 from TJ Saunders <***@castaglia.org> 2011-04-28 17:43:47 EDT ---
The Perl scripts in contrib are now installed as part of the 'make install'
target; see Bug#3616.