[ProFTPD-committers] [Bug 3651] Help with debuginfo generation in rpm build

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3651

TJ Saunders <***@castaglia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |***@castaglia.org

--- Comment #1 from TJ Saunders <***@castaglia.org> 2011-05-07 21:28:07 EDT ---
The double-slash fixes have been committed to CVS, including a similar fix for
the mod_sftp Makefile.

The sed patch is for a proftpd version that's a bit old; the current
configure.in/Makefile has an @INSTALL_STRIP@ that is part of the @INSTALL@
variable; the --enable-devel configure option also prevents the stripping of
symbols. Perhaps for the debug RPMs, simply adding the --enable-devel
configure options will suffice?

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3651

--- Comment #2 from Paul Howarth <***@city-fan.org> 2011-05-08 04:12:26 EDT ---
(In reply to comment #1)

Post by b***@horde.net
The double-slash fixes have been committed to CVS, including a similar fix for
the mod_sftp Makefile.

OK, thanks.

Post by b***@horde.net
The sed patch is for a proftpd version that's a bit old; the current
variable; the --enable-devel configure option also prevents the stripping of
symbols. Perhaps for the debug RPMs, simply adding the --enable-devel
configure options will suffice?

I'm working on the spec file for the 1.3.3 branch (package for 1.3.3e)
initially, hence the old version. Once that's ready I'll add the things needed
for 1.3.4 such as pcre/memcached support.

Does the --enable-devel option have any other effects? Debuginfo generation is
needed for regular release builds, for which we wouldn't want any devel
features such as voluminous logging of things by default or lower performance
as a result of devel features being enabled...

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3651

--- Comment #3 from TJ Saunders <***@castaglia.org> 2011-05-08 13:00:31 EDT ---
The --enable-devel configure option enables the following additional compiler
options (if the compiler is gcc, and if the gcc version supports them):

-Wfloat-equal
-Wunreachable-code
-Wformat-security
-Wstack-protector
-fstack-protector-all

and removes the -O2 optimization level compiler option.

The --enable-devel configuration option all turns some debug functions and some
different code paths in the source code, mostly for the purpose of dealing with
memory trackers like Valgrind.

Sounds like you might want a new configure option, e.g. --enable-symbols or
someusch...

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3651

--- Comment #4 from Paul Howarth <***@city-fan.org> 2011-05-08 13:37:10 EDT ---
(In reply to comment #3)

Post by b***@horde.net
Sounds like you might want a new configure option, e.g. --enable-symbols or
someusch...

Yeah, I think so. Fedora mandates specific compiler flags
(http://fedoraproject.org/wiki/PackagingGuidelines#Compiler_flags) unless
there's a good reason not to, and I expect other downstream distributors do
too.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3651

TJ Saunders <***@castaglia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED

--- Comment #5 from TJ Saunders <***@castaglia.org> 2011-05-08 14:04:05 EDT ---
OK. The current CVS code now supports an --enable-symbols configure option,
which removes the -s option from the install command, thus preventing the
stripping of symbols; there are no other side-effects of this --enable-symbols
option.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3651

--- Comment #6 from Paul Howarth <***@city-fan.org> 2011-05-08 15:05:38 EDT ---
OK thanks; any chance of a backport of this (and the double slash fixing) to
the 1.3.3 branch? Otherwise I'll have to include the hacks in the spec file...

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3651

--- Comment #7 from TJ Saunders <***@castaglia.org> 2011-05-08 15:27:26 EDT ---
Done; changes backported to 1.3.3 branch.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3651

--- Comment #8 from TJ Saunders <***@castaglia.org> 2011-05-12 22:22:19 EDT ---
Just noticed that OpenSSH's configure script uses a --disable-strip option for
not stripping symbols, versus the --enable-symbols option I added. I think
that --disable-strip is slightly more indicative; do you have a strong
preference? If not, I'll change the --enable-symbols option I added to be
--disable-strip instead.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3651

--- Comment #9 from Paul Howarth <***@city-fan.org> 2011-05-13 02:17:15 EDT ---
(In reply to comment #8)

Post by b***@horde.net
Just noticed that OpenSSH's configure script uses a --disable-strip option for
not stripping symbols, versus the --enable-symbols option I added. I think
that --disable-strip is slightly more indicative; do you have a strong
preference? If not, I'll change the --enable-symbols option I added to be
--disable-strip instead.

--disable-strip is fine with me.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3651

--- Comment #10 from TJ Saunders <***@castaglia.org> 2011-05-13 11:34:57 EDT ---
OK. Changes committed to CVS and to 1.3.3 branch.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3651

Bernd Lommerzheim <***@lommerzheim.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@lommerzheim.com

--- Comment #11 from Bernd Lommerzheim <***@lommerzheim.com> 2011-05-18 04:44:50 EDT ---
Hello TJ Saunders, I think your last commit to this bug (see comment 10) was
incomplete. It only modified the help text but it should rename the whole
configure parameter. Please review this last commit. Thanks.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3651

--- Comment #12 from TJ Saunders <***@castaglia.org> 2011-05-18 11:45:35 EDT ---
Should be fixed now, in CVS and in the 1.3.3 branch. Thanks!