[ProFTPD-committers] [Bug 3596] Some compiler warnings in a few ProFTPD modules

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3596

TJ Saunders <***@castaglia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@castaglia.org

--- Comment #1 from TJ Saunders <***@castaglia.org> 2011-02-15 16:56:01 EST ---
The mod_delay, mod_shaper, mod_tls_shmcache, and mod_sftp warnings should now
be fixed in CVS. mod_vroot is not a contrib module; it will need to be fixed
separately.

The mod_radius warnings are going to stay; I think. Those compiler warnings
arise because of compiler optimization flags, I believe (i.e. using -O2 or -O3
in the CFLAGS).

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3596

Post by b***@horde.net
The mod_radius warnings are going to stay; I think. Those compiler warnings
arise because of compiler optimization flags, I believe (i.e. using -O2 or -O3
in the CFLAGS).

Yes, I was using the -O2 optimization flag when those compiler warnings arose.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3596

display.c:35: warning: 'format_size_str' defined but not used

This warning belongs to the src/display.c file and not to the
contrib/mod_sftp/display.c file. Sorry, I should have mentioned that before.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3596

--- Comment #4 from TJ Saunders <***@castaglia.org> 2011-02-16 14:48:37 EST ---
No worries. Looking at both src/display.c and contrib/mod_sftp/display.c, I
found that that format_size_str() function should be being used. This should
now be fixed in CVS.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3596

--- Comment #5 from TJ Saunders <***@castaglia.org> 2011-02-25 15:24:47 EST ---
I believe all of the warnings pertaining to the standard ProFTPD source code
have been addressed. Can you confirm this, and if so close this bug report?

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3596

Post by b***@horde.net
I believe all of the warnings pertaining to the standard ProFTPD source code
have been addressed. Can you confirm this, and if so close this bug report?

Yes, I can confirm this. But while building ProFTPD CVS 20110226 I get a new
warning:
response.c:38: warning: 'resp_ml_numeric' defined but not used

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3596

TJ Saunders <***@castaglia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED

--- Comment #7 from TJ Saunders <***@castaglia.org> 2011-02-26 12:10:54 EST ---
OK, I've removed that unused variable from src/response.c in CVS. Closing this
bug. Thanks!

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3596

TJ Saunders <***@castaglia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED

--- Comment #8 from TJ Saunders <***@castaglia.org> 2011-04-06 03:41:04 EDT ---
Resolved in 1.3.4rc2.