[ProFTPD-committers] [Bug 3609] Support full PCRE regular expressions if PCRE support is enabled

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3609

TJ Saunders <***@castaglia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |***@debian.org,
| |***@city-fan.org

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3609

--- Comment #1 from TJ Saunders <***@castaglia.org> 2011-02-28 20:55:56 EST ---
Created attachment 3560
--> http://bugs.proftpd.org/attachment.cgi?id=3560
Adds requested functionality

This patch adds full PCRE usage support to ProFTPD's Regexp API. As such, it
is largely noticeable to the end user -- except that if --enable-pcre is used,
they should be able to use Perl-compatible regular expressions for any of the
ProFTPD directives which take regular expressions (e.g. PathAllowFilter,
PathDenyFilter, mod_ifsession, etc). One notable exception is mod_rewrite; for
now, I felt it wiser to stick with POSIX regex semantics for mod_rewrite's
regexes.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3609

TJ Saunders <***@castaglia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #3560|0 |1
is obsolete| |

--- Comment #2 from TJ Saunders <***@castaglia.org> 2011-02-28 22:00:39 EST ---
Created attachment 3561
--> http://bugs.proftpd.org/attachment.cgi?id=3561
Updates previous patch

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3609

TJ Saunders <***@castaglia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #3561|0 |1
is obsolete| |

--- Comment #3 from TJ Saunders <***@castaglia.org> 2011-03-01 12:33:20 EST ---
Created attachment 3562
--> http://bugs.proftpd.org/attachment.cgi?id=3562
Updates previous patch

Updates previous patch, removing the pr_regexp_exec_pcre() function. Callers
who don't care about whether their pattern is compiled as a POSIX or PCRE
regular expression can call pr_regexp_compile(); if PCRE support is enabled, it
will be compiled as a PCRE regular expression, otherwise as a POSIX regular
expression. Callers explicitly wanting POSIX regular expressions can call
pr_regexp_compile_posix(). In either case, the compiled pattern has enough
information for pr_regexp_exec() to execute the compiled pattern (either PCRE
or POSIX) the right way.

Having callers use pr_regexp_compile_pcre() when PCRE support is not enabled is
not a situation worth supporting; the above approach handles things simply and
efficiently.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3609

TJ Saunders <***@castaglia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED

--- Comment #4 from TJ Saunders <***@castaglia.org> 2011-03-03 16:39:30 EST ---
Patch committed to CVS.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3609

TJ Saunders <***@castaglia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED

--- Comment #5 from TJ Saunders <***@castaglia.org> 2011-04-06 03:49:13 EDT ---
Resolved in 1.3.4rc2.