[ProFTPD-committers] [Bug 3598] HiddenStores makes the APPE command overwrite files instead of appending them

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3598

Rob V. <***@porthus.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@porthus.com

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3598

TJ Saunders <***@castaglia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |***@castaglia.org
Platform|PC |All
OS/Version|Linux |All
Severity|major |normal

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3598

--- Comment #1 from TJ Saunders <***@castaglia.org> 2011-02-16 20:55:05 EST ---
Created attachment 3546
--> http://bugs.proftpd.org/attachment.cgi?id=3546
Fixes behavior

This patch causes mod_xfer to refuse an APPE command if HiddenStores is in
effect, which it should do; it already refuses a restarted (via REST) upload
via STOR if HiddenStores is in effect.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3598

TJ Saunders <***@castaglia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED

--- Comment #2 from TJ Saunders <***@castaglia.org> 2011-02-16 21:12:19 EST ---
Patch committed to CVS with accompanying unit test. Thanks!

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3598

--- Comment #3 from Rob V. <***@porthus.com> 2011-03-31 10:36:27 EDT ---
In the mean time, I created a patch wich does allow APPEND + Hiddenstores, by
renaming the existing file again to a hiddenfile and then appending to it.
Please note that my C skills are questionable at best, and so is the patch (
but I haven't found any problems with it yet, at least for my use case ). If
anyone wan't to review it, be my guest.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3598

--- Comment #4 from Rob V. <***@porthus.com> 2011-03-31 10:38:23 EDT ---
Created attachment 3599
--> http://bugs.proftpd.org/attachment.cgi?id=3599
Patch - Makes APPEND + Hiddenstores work

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3598

TJ Saunders <***@castaglia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED

--- Comment #5 from TJ Saunders <***@castaglia.org> 2011-04-06 03:43:47 EDT ---
Resolved in 1.3.4rc2.

The issue with resuming (via REST) or appending (via APPE) with any
HiddenStores file is when you have a client which opens multiple simultaneous
connections, and uses each connection to try to upload a different byte range
(i.e. a "chunk") of a large file. When each chunk upload finishes, what
happens to all those HiddenFiles, and how to merge them all together? The
server doesn't know that all these "chunks" are somehow part of the same file.
This is why REST/APPE+HiddenStores is denied.