[ProFTPD-committers] [Bug 3656] Deceptive error message for MaxStoreFilesize

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3656

TJ Saunders <***@castaglia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@castaglia.org

--- Comment #1 from TJ Saunders <***@castaglia.org> 2011-05-15 13:09:19 EDT ---
This is a very cosmetic issue, and it's not one I'm inclined to change/fix.
How exactly is the error message causing problems, if at all? The server-side
logging will show the cause of the issue being MaxStoreFileSize.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3656

--- Comment #2 from Erno Kovacs <***@freemail.hu> 2011-05-15 15:03:19 EDT ---
The current error message suggests that the error is at server side.
If it was a correct error message, then I could have tell the customer
immediately that this is an user error.

And while typing your last reply you could have already fix this line in the
source cure and Proftpd would be better.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3656

--- Comment #3 from TJ Saunders <***@castaglia.org> 2011-05-15 15:36:54 EDT ---
In the case where you configure a MaxStoreFileSize, then it *is* a server-side
policy -- it is not a client-side error of any sort. Changing the error
message to imply that it's a client/user error is not correct, either -- the
user has no idea that the server is configured with a MaxStoreFileSize error,
and the user has done nothing wrong.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3656

--- Comment #4 from TJ Saunders <***@castaglia.org> 2011-05-17 00:18:12 EDT ---
Would "File too large" error message be better, in your opinion? Right now,
proftpd uses the EDQUOT errno value when the MaxStoreFileSize limit is reached;
the string associated with EDQUOT is "Disk quota exceeded". By contrast, if
your platform supports the EFBIG errno value, then the error message seen by
the client would show "File too large". Would that error message be more
acceptable to you?

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3656

--- Comment #5 from Erno Kovacs <***@freemail.hu> 2011-05-17 03:43:05 EDT ---
Ok the original story is:
The service we provide for the users has a limitation of 50MB / file.
Clients are beware of this limitation, and they thought its server side error,
as the error message suggests.

"File is too large" error message would be perfect.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3656

TJ Saunders <***@castaglia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Priority|P2 |P5
Status|NEW |ASSIGNED
Component|core |mod_xfer
Platform|PC |All
Severity|normal |trivial

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3656

TJ Saunders <***@castaglia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|Deceptive error message for |Prefer "File too big" error
|MaxStoreFilesize |message for
| |MaxStoreFilesize

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3656

--- Comment #6 from TJ Saunders <***@castaglia.org> 2011-05-17 13:24:21 EDT ---
Created attachment 3618
--> http://bugs.proftpd.org/attachment.cgi?id=3618
Makes requested change

This patch will change the error message as requested.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3656

TJ Saunders <***@castaglia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED

--- Comment #7 from TJ Saunders <***@castaglia.org> 2011-05-17 13:26:17 EDT ---
Patch committed to CVS.

Note that since this is a cosmetic change, not fixing a bug or security issue,
this change will not be backported to the 1.3.3 branch.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3656

--- Comment #8 from Erno Kovacs <***@freemail.hu> 2011-05-17 16:23:33 EDT ---
Thank you TJ!