[ProFTPD-committers] [Bug 3610] Proftpd is eating CPU when reparsing configuration file on SIGHUP

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3610

TJ Saunders <***@castaglia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@castaglia.org

--- Comment #1 from TJ Saunders <***@castaglia.org> 2011-03-03 10:12:25 EST ---
Could you please provide the proftpd.conf you're using, including any Include
files, so that I can try to reproduce this problem locally?

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3610

--- Comment #2 from ***@free.fr 2011-03-04 05:08:36 EST ---
Created attachment 3565
--> http://bugs.proftpd.org/attachment.cgi?id=3565
proftpd configuration files for bug 3610 - tar

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3610

TJ Saunders <***@castaglia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |***@ordal.com,
| |***@maytech.net
Platform|Other |All
OS/Version|Linux |All

--- Comment #3 from TJ Saunders <***@castaglia.org> 2011-03-25 02:18:52 EDT ---
I'm able to reproduce this issue locally now. From my investigations so far,
it is a combination of the number of <Directory>/<Limit> sections AND the way
that mod_sql handles the SQLLog directive. Without the SQLLog configuration,
the restart time/CPU load is nowhere near as high. I'm going to keep
investigating, but wanted to keep notes of the investigation here.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3610

--- Comment #4 from TJ Saunders <***@castaglia.org> 2011-03-25 15:11:26 EDT ---
Created attachment 3597
--> http://bugs.proftpd.org/attachment.cgi?id=3597
Fixes bug (hopefully)

This patch (generated against the current CVS sources) greatly reduces the CPU
usage during a restart; it fixes the mod_sql module to not use the MERGEDOWN
config flag as much as it does.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3610

TJ Saunders <***@castaglia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Keywords| |Backport

--- Comment #5 from TJ Saunders <***@castaglia.org> 2011-03-25 20:21:52 EDT ---
Given the severity of the problem during a restart, I think this patch warrants
backporting as well.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3610

--- Comment #6 from TJ Saunders <***@castaglia.org> 2011-03-25 20:49:48 EDT ---
Created attachment 3598
--> http://bugs.proftpd.org/attachment.cgi?id=3598
Fixes bug in 1.3.3 branch

And here's a version of the patch for the 1.3.3 branch.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3610

TJ Saunders <***@castaglia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
CC| |***@debian.org,
| |***@city-fan.org
Resolution| |FIXED

--- Comment #7 from TJ Saunders <***@castaglia.org> 2011-03-25 20:51:17 EDT ---
Patch committed to CVS, with accompanying regression test, and backported to
1.3.3 branch.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3610

--- Comment #8 from ***@free.fr 2011-03-28 07:31:03 EDT ---
Thanks for the quick 1.3.3 patch.
Cpu cut by 3; still high (reload will cause unavailibility > 45 sec. on current
production hardware - some clients may time-out), but not unaceptable...

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3610

--- Comment #9 from TJ Saunders <***@castaglia.org> 2011-03-28 16:29:36 EDT ---
There have also been some performance improvements in the 1.3.4 RCs. I'm just
about to release 1.3.4rc2. If you get a chance, you could see if it performs
better when reloading your particular configuration.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3610

TJ Saunders <***@castaglia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED

--- Comment #10 from TJ Saunders <***@castaglia.org> 2011-04-06 03:49:42 EDT ---
Resolved in 1.3.4rc2.