[ProFTPD-committers] [Bug 3602] Support BufferedLogs directive for more efficient disk IO

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3602

--- Comment #1 from TJ Saunders <***@castaglia.org> 2011-03-20 16:00:28 EDT ---
I can see why Apache marks this feature as "experimental". By buffering up log
messages, the chances of interleaved log messages become a lot higher.
Especially if multiple log file directives are pointed at the same filesystem
path.

In addition, any such buffering would need to flush the pending log messages
based on the end-of-line (i.e. newline) boundaries, not on the optimal block
size for the underlying filesystem. Otherwise, the messages again risk being
interleaved.

[b***@horde.net]

http://bugs.proftpd.org/show_bug.cgi?id=3602

--- Comment #2 from TJ Saunders <***@castaglia.org> 2011-04-26 12:21:23 EDT ---
To avoid the inter-message interleaving, a ring buffer/linked list of
individual log messages can be used, with writev(2) to write out a list of
messages. This does not mitigate the inter-leaving of different module
messages to the same file, however.